Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: admin config init #8546

Merged
merged 7 commits into from
Feb 5, 2021
Merged

feat: admin config init #8546

merged 7 commits into from
Feb 5, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 4, 2021

Changes:

Refactors multiple admin-only fields into a new "admin" config.

Context:

We want complete separation of options which users can change and those they can't.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins marked this pull request as draft February 4, 2021 18:46
@rarkins rarkins marked this pull request as ready for review February 4, 2021 18:59
@rarkins rarkins force-pushed the refactor/admin-config-platform branch from 081b714 to 9b118ae Compare February 4, 2021 20:31
lib/config/admin.ts Outdated Show resolved Hide resolved
lib/config/admin.ts Show resolved Hide resolved
viceice
viceice previously approved these changes Feb 5, 2021
@rarkins rarkins merged commit 4e2c33f into master Feb 5, 2021
@rarkins rarkins deleted the refactor/admin-config-platform branch February 5, 2021 08:20
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.39.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants