Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(datasource/crate): Add missing httpMock.setup/reset() calls #8566

Merged
merged 1 commit into from
Feb 6, 2021

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Feb 6, 2021

Changes:

This PR adds httpMock.setup/reset() calls to the test suite of the crates.io datasource.

Context:

All other tests suites that use the httpMock are calling setup() at the start of the test, and reset() afterwards. In the current state, the snapshots of the tests for this datasource are wrong, because they include the request traces of the previous tests since the HTTP mock is never reset. This PR fixes the issue and updates the snapshots.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge (squash) February 6, 2021 12:43
@rarkins rarkins merged commit 4238736 into renovatebot:master Feb 6, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.42.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2021
@Turbo87 Turbo87 deleted the mocks branch August 30, 2021 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants