Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update preset hosting docs #8591

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Feb 8, 2021

Changes:

  • Change heading title
  • Move npm section to bottom of document
  • Add deprecation notice about npm hosted presets

Context:

Closes #8464.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose
Copy link
Collaborator Author

@viceice Could you help me with figuring out what the file based preset section should say? I have no clue where to begin... 😄

@HonkingGoose
Copy link
Collaborator Author

Do we want to remove all mentions of npm here? There's still some mentions of npm in this file right now...

@viceice
Copy link
Member

viceice commented Feb 8, 2021

I think we should add a section to the bottom.

@rarkins What do you think?

@rarkins
Copy link
Collaborator

rarkins commented Feb 9, 2021

@HonkingGoose new idea: you don't need to keep updating docs-only PRs to be up to date with master unless they're conflicted. I can use admin privileges to merge anyway, and it probably saves us all time

@HonkingGoose
Copy link
Collaborator Author

@HonkingGoose new idea: you don't need to keep updating docs-only PRs to be up to date with master unless they're conflicted. I can use admin privileges to merge anyway, and it probably saves us all time

I like knowing for sure that my stuff works with the latest changes on master, so that's why I merged so frequently.
I'll stop merging master so frequently on docs-only PRs from now on. 😉

viceice
viceice previously approved these changes Apr 8, 2021
@viceice
Copy link
Member

viceice commented Apr 8, 2021

needs deconflicting

@HonkingGoose HonkingGoose marked this pull request as ready for review April 8, 2021 08:12
@viceice viceice enabled auto-merge (squash) April 22, 2021 13:30
@viceice viceice merged commit 43907c1 into renovatebot:master Apr 22, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the docs/issue-8464-update-preset-hosting-docs branch April 22, 2021 19:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update preset hosting docs
4 participants