fix(batect): "Failed to parse newContent" #8632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This fixes an issue where all updates with the
batect
manager would fail.It also adds logging for errors like this so that they're easier to diagnose in the future.
Context:
Updates to Batect configuration files (either Docker image references or bundle versions) were broken. Logs would contain messages like this:
The error parsing
newContent
is due toauto-replace.ts
expecting the manager to implementextractPackageFile
, but the Batect manager doesn't implement this, and instead provided onlyextractAllPackageFiles
(see #8091 for more details).I haven't added a unit test for this, but if there's an existing pattern for tests that would catch this kind of problem, please let me know and I can add one.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: