-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce code issues #8639
fix: reduce code issues #8639
Conversation
COPY --from=image9 | ||
|
||
COPY\ | ||
--chown=root \ | ||
# comment1 | ||
# | ||
#comment2 | ||
--from=image10 | ||
# comment2 | ||
path1 path2 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid docker syntax
Object { | ||
"autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}", | ||
"currentDigest": undefined, | ||
"currentValue": undefined, | ||
"datasource": "docker", | ||
"depName": "image9", | ||
"depType": "stage", | ||
"replaceString": "image9", | ||
}, | ||
Object { | ||
"autoReplaceStringTemplate": "{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}", | ||
"currentDigest": undefined, | ||
"currentValue": undefined, | ||
"datasource": "docker", | ||
"depName": "image10", | ||
"depType": "stage", | ||
"replaceString": "image10", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From invalid docker syntax
'lib/manager/dockerfile/__fixtures__/Dockerfile1', | ||
'lib/manager/dockerfile/__fixtures__/1.Dockerfile', | ||
'utf8' | ||
); | ||
|
||
const d2 = readFileSync( | ||
'lib/manager/dockerfile/__fixtures__/Dockerfile2', | ||
'lib/manager/dockerfile/__fixtures__/2.Dockerfile', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For syntax highlighting in vscode 😉
@@ -10,7 +10,7 @@ import { | |||
} from './common'; | |||
|
|||
const artifactRegex = regEx( | |||
'^[a-zA-Z][-_a-zA-Z0-9]*(?:.[a-zA-Z0-9][-_a-zA-Z0-9]*)*$' | |||
'^[a-zA-Z][-_a-zA-Z0-9]*(?:\\.[a-zA-Z0-9][-_a-zA-Z0-9]*?)*$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only match dot
🎉 This PR is included in version 24.46.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Fix some codeql isues:
gradle-lite
: greedy regexContext:
Fixes CodeQL errors
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: