Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use object not array for helm cache #8733

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 17, 2021

Changes:

Refactors helm caching to use an object instead of array.

Context:

Makes #8715 simpler.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice February 17, 2021 13:49
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a little thing otherewise LGTM

lib/datasource/helm/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice February 17, 2021 13:58
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now 🙃

@viceice viceice enabled auto-merge (squash) February 17, 2021 15:37
@viceice viceice merged commit 720907e into master Feb 17, 2021
@viceice viceice deleted the refactor/helm-cache branch February 17, 2021 15:52
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants