Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: matchFiles #8769

Merged
merged 2 commits into from
Feb 19, 2021
Merged

feat: matchFiles #8769

merged 2 commits into from
Feb 19, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 19, 2021

Changes:

Adds matchFiles to packageRules.

Context:

The current "substring" support in matchPaths is too flexible for some situations and doing simple rules like match package.json but not packages/backend/package.json is too hard. matchFiles is exact match only.

I've chosen matchFiles instead of matchPackageFiles in case we find a use for matching against a lock file later.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Feb 19, 2021
@rarkins rarkins changed the title feat: matchPackageFiles feat: matchFiles Feb 19, 2021
@rarkins rarkins requested a review from viceice February 19, 2021 15:19
@rarkins rarkins merged commit 6b49402 into master Feb 19, 2021
@rarkins rarkins deleted the feat/match-package-files branch February 19, 2021 15:29
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice mentioned this pull request Mar 11, 2021
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants