Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: per-file vulnerability alerts #8770

Merged
merged 6 commits into from
Feb 20, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 19, 2021

Changes:

Processes GitHub Vulnerability Alerts on a per-file basis and sets the result in matchFiles.

Context:

GitHub's alert may specify a particular file but until now Renovate would try to locate and fix it in every file. I noticed this as a problem when it was matching peerDependencies unnecessarily in a repo a while back.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice February 19, 2021 15:30
@rarkins rarkins changed the title feat: matchPackageFiles feat: per-file vulnerability alerts Feb 19, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see any ovious issue 🙃

@rarkins rarkins enabled auto-merge (squash) February 20, 2021 05:46
@rarkins rarkins merged commit 2c9a172 into master Feb 20, 2021
@rarkins rarkins deleted the feat/per-file-vulnerability-alerts branch February 20, 2021 06:00
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.57.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants