Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use small delay before posting branch status to gitlab (#8759) #8771

Merged
merged 2 commits into from
Feb 20, 2021
Merged

fix: use small delay before posting branch status to gitlab (#8759) #8771

merged 2 commits into from
Feb 20, 2021

Conversation

bobvandevijver
Copy link
Contributor

Changes:

This PR adds a small delay before calling the Gitlab API to add a branch status.

Context:

This should hopefully fix the race condition as described in #8759

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the `delay' needs to be mocked in tests to not slow down

@bobvandevijver
Copy link
Contributor Author

Correct me if I'm wrong, but I think that is already done here, probably for the other delay that was already in the changed file:

jest.mock('delay');

@viceice viceice enabled auto-merge (squash) February 20, 2021 14:48
@viceice viceice merged commit e1ec04e into renovatebot:master Feb 20, 2021
@bobvandevijver bobvandevijver deleted the patch-1 branch February 20, 2021 15:09
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.59.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants