Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support #9111

Closed
rarkins opened this issue Mar 13, 2021 · 2 comments
Closed

Remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support #9111

rarkins opened this issue Mar 13, 2021 · 2 comments
Assignees
@rarkins
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 13, 2021

What would you like Renovate to be able to do?

No longer use RENOVATE_LEGACY_GIT_AUTHOR_EMAIL

Did you already have any implementation ideas?

Document it in a breaking release, recommend gitIgnoredAuthors instead
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code breaking Breaking change, requires major version bump status:ready labels Mar 13, 2021
@rarkins rarkins mentioned this issue Mar 13, 2021
Merged
6 tasks
@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Mar 13, 2021 •
edited

If we're removing this from the code, we also need to remove it from the docs fully.

Searching for RENOVATE_LEGACY_GIT_AUTHOR_EMAIL gives one hit on current master in the docs/usage/self-hosted-configuration.md file. 😉

Link to file and section where the old property is mentioned: https://github.com/renovatebot/renovate/blob/master/docs/usage/self-hosted-configuration.md#gitauthor

@rarkins rarkins self-assigned this Apr 4, 2021
@rarkins rarkins added status:in-progress Someone is working on implementation and removed status:ready labels Apr 4, 2021
rarkins added a commit that referenced this issue Apr 4, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
7a2d672 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 5, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
229a835 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 5, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
4cf313c 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 5, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
596faf3 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
@rarkins rarkins mentioned this issue Apr 7, 2021
Merged
rarkins added a commit that referenced this issue Apr 7, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
79b16d5 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 10, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
841d1b7 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 11, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
9673754 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 15, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
0914fd2 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 21, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
8496f40 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 22, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
907e908 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 22, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
6dfae37 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
rarkins added a commit that referenced this issue Apr 22, 2021
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
482012a 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rarkins rarkins

Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rarkins @HonkingGoose @renovate-release