feat(terraform): rework dep types #9116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secustor
changed the title
HonkingGoose
suggested changes
Mar 13, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
| @@ -1,19 +1,36 @@ | |||
| Currently Terraform support is limited to Terraform registry sources and github sources that include SemVer refs, e.g. like `github.com/hashicorp/example?ref=v1.0.0`. | |||
| Currently, Terraform supports renovating the following dependencies, where sub points represent hosting options of the dependencies: | |||
There was a problem hiding this comment.
Suggested change
| Currently, Terraform supports renovating the following dependencies, where sub points represent hosting options of the dependencies: | |
| Terraform supports renovating the following dependencies, where sub points represent hosting options of the dependencies: |
To me the use of the words "Currently, " implies that on a later date Renovate/Terraform will support more renovations. By not using such words as "currently, later, right now, in future" we don't create expectations of further improvements. The sentence would read just as nice if we removed the word "Currently, ".
Also by not using words like "Currently" we free ourselves from updating the docs when at a later time "Currently, Terraform supports..." some other renovation as well.
So overall, I think using "time-based" language like this is a bit dangerous.
But let's see what the rest of the Renovate team thinks about using words like this in our docs...
So don't rush into applying this suggestion right away, as I'm curious what the rest of the Renovate team has to say. Maybe I'm totally honking up the wrong pond here... 😄
|
FYI I'm marking all breaking change PRs as draft to reduce the chance of accidental merge |
rarkins
changed the title
rarkins
previously approved these changes
Apr 4, 2021
|
@secustor I seem to have broken this in the merge. Could you take a look? |
|
@rarkins Seems like a new test has been added, fixed the snapshot. |
rarkins
pushed a commit
that referenced
this pull request
Apr 5, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 5, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 5, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 7, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 10, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 11, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 15, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 21, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 22, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 22, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 22, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
rarkins
pushed a commit
that referenced
this pull request
Apr 22, 2021
Improves the `depType` values returned by the terraform manager. Closes #8792 BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR changes all
depTypesprovided by the Terraform manger to allow a more fain grained control over which dependencies are updated and which are not.Context:
Closes #8792
I'm not sure how to do the migration for users which use the
helmdepType.Can you point me to some example PR where this has already been done?
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: