lint and warn when a packageRule object has both matchUpdateTypes AND allowedVersions

[HonkingGoose]

What would you like Renovate to be able to do?

A user was trying to exclude certain Docusaurus v2 releases with this config:

"packageRules": [
    {
      "description": "Allow mainline @docusaurus releases, ignore canary releases",
      "groupName": "docusaurus monorepo",
      "matchSourceUrlPrefixes": ["https://github.com/facebook/docusaurus"],
      "matchUpdateTypes": ["major", "minor", "patch"],
      "allowedVersions": "!/\\b([a-f0-9]{9})?$/"
    }
  ]

Renovate still opened PRs to update to the canary releases. The user asked why it was not working.

@rarkins then said (emphasis mine):

You can't mix matchUpdateTypes with allowedVersions in the same package rule. It's something we should try to lint and warn about, but we don't yet. The reason is because versions filtering is done the step before we know the update type. So by the time you. know the update type and match the rule, it's too late to apply the allowedVersions rule. I don't think that extra line achieves anything though and can be removed.

So the requirement is:

IF a packageRule object
HAS matchUpdateTypes AND allowedVersions
THEN warn user that this is not a valid combination by raising a config warning issue on their repo.

Did you already have any implementation ideas?

I'll let the Renovate developers figure out how to implement this. 😉

[HonkingGoose]

@rarkins does PR #9649 resolve this issue? Or do we need extra code to resolve this?

[HonkingGoose]

@rarkins Thank you for fixing this. 😄 ❤️

[rarkins]

Thanks for documenting it in an issue!

[renovate-release]

🎉 This issue has been resolved in version 25.1.1 🎉

The release is available on:

• GitHub release
• 25.1.1

Your semantic-release bot 📦🚀