Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): remove manager additionalBranchPrefix defaults #9373

Merged
merged 4 commits into from Apr 4, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 3, 2021

Changes:

Resets any language or manager additionalBranchPrefix values to empty string. Add the compatibility:additionalBranchPrefix prefix to restore previous behavior.

Context:

BREAKING CHANGE: Removal of default additionalBranchPrefix values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Resets any language or manager additionalBranchPrefix values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default additionalBranchPrefix values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
@rarkins rarkins added the breaking Breaking change, requires major version bump label Apr 3, 2021
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins changed the title feat(config): empty manager additionalBranchPrefix feat(config): remove manager additionalBranchPrefix defaults Apr 4, 2021
@rarkins rarkins changed the base branch from master to v25 April 4, 2021 07:12
@rarkins rarkins marked this pull request as ready for review April 4, 2021 07:31
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enabled by default? Should we mention it on docs?

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 4, 2021

Is this enabled by default? Should we mention it on docs?

We're removing defaults now, so it will cause some autoclosing/reopening due to branch name changes. Not sure if any further documentation will really help.

@rarkins rarkins merged commit 2ee681f into v25 Apr 4, 2021
@rarkins rarkins deleted the breaking/manager-additional-branch-prefix branch April 4, 2021 09:02
rarkins added a commit that referenced this pull request Apr 5, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 5, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 5, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 7, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 10, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 11, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 15, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 21, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 22, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 22, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 22, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
rarkins added a commit that referenced this pull request Apr 22, 2021
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants