Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split trustLevel into separate options #9388

Merged
merged 1 commit into from Apr 4, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 4, 2021

Changes:

Removes trustLevel and replaces it with 3 other options instead.

Context:

We shouldn't need it to be "all or nothing".

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

BREAKING CHANGE: trustLevel is no longer supported and instead broken into allowCustomCrateRegistries , allowScripts , and exposeAllEnv.

@rarkins rarkins added the breaking Breaking change, requires major version bump label Apr 4, 2021
@rarkins rarkins changed the base branch from master to v25 April 4, 2021 07:12
@rarkins rarkins marked this pull request as ready for review April 4, 2021 07:31
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should start logging a warning for outdated config?

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 4, 2021

Maybe we should start logging a warning for outdated config?

I'm not sure we should warn people about something they can't change yet. Self-hosted users need to read the v25 release notes and update their admin config accordingly.

@rarkins rarkins merged commit 2eb962c into v25 Apr 4, 2021
@rarkins rarkins deleted the breaking/trust-level branch April 4, 2021 09:02
Comment on lines +187 to +188
By default, Renovate will only pass a limited set of environment variables to package managers.
Potentially, there could be leaks of confidential data if a script you don't trust enumerates all values in env, so set this to true only if you trust the repositories which the bot runs against.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, Renovate will only pass a limited set of environment variables to package managers.
Potentially, there could be leaks of confidential data if a script you don't trust enumerates all values in env, so set this to true only if you trust the repositories which the bot runs against.
By default, Renovate only passes a limited set of environment variables to package managers.
Confidential data can be leaked if a malicious script enumerates all environment variables.
Set `exposeAllEnv` to `true` only if you have reviewed (and trust) the repositories which Renovate bot runs against.

How about this?

By default, Renovate will only pass a limited set of environment variables to package managers.
Potentially, there could be leaks of confidential data if a script you don't trust enumerates all values in env, so set this to true only if you trust the repositories which the bot runs against.

Setting this to true will also allow for variable substitution in `.npmrc` files.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Setting this to true will also allow for variable substitution in `.npmrc` files.
Setting this to `true` will also allow for variable substitution in `.npmrc` files.

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 4, 2021

@HonkingGoose sorry, can you submit a separate docs PR against the v25 branch with these proposed changes?

@HonkingGoose
Copy link
Collaborator

A sneaky ninja merged this while I was reviewing... 👻 😄

I'll go open a PR. 😉

rarkins added a commit that referenced this pull request Apr 5, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 5, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 5, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 7, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 10, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 11, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 15, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 21, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants