New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove logLevel support in config #9390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI.
viceice
previously approved these changes
Apr 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not a deprecation, it's a feature removal 🤔
rarkins
changed the title
feat: deprecate logLevel in config
feat: remove logLevel support in config
Apr 4, 2021
viceice
approved these changes
Apr 4, 2021
rarkins
added a commit
that referenced
this pull request
Apr 5, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 5, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 5, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 7, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 10, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 11, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 15, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 21, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead. Closes #8291 BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.
Context:
Closes #8291
BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: