Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove logLevel support in config #9390

Merged
merged 2 commits into from Apr 4, 2021
Merged

feat: remove logLevel support in config #9390

merged 2 commits into from Apr 4, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 4, 2021

Changes:

Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Context:

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI.
@rarkins rarkins added the breaking Breaking change, requires major version bump label Apr 4, 2021
viceice
viceice previously approved these changes Apr 4, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a deprecation, it's a feature removal 🤔

@rarkins rarkins changed the title feat: deprecate logLevel in config feat: remove logLevel support in config Apr 4, 2021
@rarkins rarkins changed the base branch from master to v25 April 4, 2021 07:11
@rarkins rarkins marked this pull request as ready for review April 4, 2021 07:30
@rarkins rarkins merged commit a5c785a into v25 Apr 4, 2021
@rarkins rarkins deleted the breaking/log-level branch April 4, 2021 08:58
rarkins added a commit that referenced this pull request Apr 5, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 5, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 5, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 7, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 10, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 11, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 15, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 21, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
rarkins added a commit that referenced this pull request Apr 22, 2021
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove logLevel config option
2 participants