Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drop NPM_TOKEN support #9391

Merged
merged 3 commits into from Apr 4, 2021
Merged

feat: drop NPM_TOKEN support #9391

merged 3 commits into from Apr 4, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 4, 2021

Changes:

Removes support for NPM_TOKEN.

Context:

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
feat(npm): deprecate NPM_TOKEN
a147f32 
NPM_TOKEN can no longer be used to configure npm auth. Please configure hostRules instead.
@rarkins
feat: drop NPM_TOKEN support
cc3004d 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
@rarkins rarkins added the breaking Breaking change, requires major version bump label Apr 4, 2021
viceice
viceice reviewed Apr 4, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add deprecation warnings for all those feature removal now. Do people are more aware of the breaking changes

@rarkins rarkins changed the base branch from master to v25 April 4, 2021 07:10
@rarkins
Merge branch 'v25' into breaking/npm-token
390b935 
# Conflicts:
#	lib/datasource/npm/npmrc.ts
@rarkins
Copy link
Collaborator Author

rarkins commented Apr 4, 2021

We should add deprecation warnings for all those feature removal now. Do people are more aware of the breaking changes

Pushed a log WARN to master just now

@rarkins rarkins requested a review from viceice April 4, 2021 07:24
@rarkins rarkins marked this pull request as ready for review April 4, 2021 07:30
@rarkins rarkins merged commit 69ea8fc into v25 Apr 4, 2021
@rarkins rarkins deleted the breaking/npm-token branch April 4, 2021 07:36
rarkins added a commit that referenced this pull request Apr 5, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
49f08da 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 5, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
75aca40 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 5, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
cbdc47b 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 7, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
eb6307e 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 10, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
4ea3ade 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 11, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
d0f0cd7 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 15, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
129eaa4 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 21, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
b6aa62d 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
86ea202 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
cec7003 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
8516aac 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat: drop NPM_TOKEN support (#9391)
5701504 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rarkins @viceice