Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(npm): remove ~/.npmrc support #9400

Merged
merged 32 commits into from Apr 6, 2021
Merged

feat(npm): remove ~/.npmrc support #9400

merged 32 commits into from Apr 6, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 4, 2021 •
edited

Changes:

Removes support for reading .npmrc from ~.

Context:

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure npmrc in config instead.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins and others added 9 commits April 4, 2021 09:18
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
7a2d672 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
@rarkins
feat: drop NPM_TOKEN support (#9391)
69ea8fc 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
@rarkins
feat: remove logLevel support in config (#9390)
a5c785a 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
@rarkins
feat: split trustLevel into separate options (#9388)
2eb962c 
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
@rarkins
feat(config): remove manager additionalBranchPrefix defaults (#9373)
2ee681f 
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
@rarkins
feat: updateType=patch (#9393)
ff15c91 
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
@secustor
feat(terraform): rework dep types (#9116)
e5fc93e 
Improves the `depType` values returned by the terraform manager.

Closes #8792

BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
@HonkingGoose
docs: improve sentences (#9395)
bb95d9e
@rarkins
feat(npm): deprecate ~/.npmrc support
7504640 
Deprecates support for reading `.npmrc` from ~.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
@rarkins rarkins requested a review from viceice April 4, 2021 19:37
@rarkins rarkins added the breaking Breaking change, requires major version bump label Apr 4, 2021
viceice
viceice requested changes Apr 5, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a wrong merge here. Please rebase and force push.

Also I think this is not a deprecation, it's a removal.

docs/usage/self-hosting.md Outdated

Note that some Renovate configuration options are _only_ available for self-hosting, and so can only be configured using one of the above methods.
These are described in the [Self-hosted Configuration](./self-hosted-configuration.md) doc.

If you are configuring using environment variables, there are two possibilities:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong merge?

@rarkins rarkins changed the title feat(npm): deprecate ~/.npmrc support feat(npm): remove ~/.npmrc support Apr 5, 2021
rarkins and others added 8 commits April 5, 2021 11:43
@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
229a835 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
@rarkins
feat: drop NPM_TOKEN support (#9391)
49f08da 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
@rarkins
feat: remove logLevel support in config (#9390)
07439a5 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
@rarkins
feat: split trustLevel into separate options (#9388)
f9b9614 
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
@rarkins
feat(config): remove manager additionalBranchPrefix defaults (#9373)
8c19baf 
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
@rarkins
feat: updateType=patch (#9393)
d954ea7 
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
@secustor @rarkins
feat(terraform): rework dep types (#9116)
d723b58 
Improves the `depType` values returned by the terraform manager.

Closes #8792

BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
@HonkingGoose @rarkins
docs: improve sentences (#9395)
971ae10
@rarkins
Merge branch 'v25' into breaking/npmrc-home-dir
bf45146 
# Conflicts:
#	docs/usage/private-modules.md
@rarkins rarkins requested a review from viceice April 5, 2021 09:47
viceice
viceice reviewed Apr 5, 2021
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the code removal lost while rebase? Or is it docs only?

@rarkins
feat: remove RENOVATE_LEGACY_GIT_AUTHOR_EMAIL (#9389)
4cf313c 
Removes RENOVATE_LEGACY_GIT_AUTHOR_EMAIL support. 

Closes #9111

BREAKING CHANGE: RENOVATE_LEGACY_GIT_AUTHOR_EMAIL is no longer supported. Use `ignoredAuthors` in config instead.
@rarkins
feat: drop NPM_TOKEN support (#9391)
75aca40 
Removes support for NPM_TOKEN.

BREAKING CHANGE: Do not use NPM_TOKEN in env to configure npm authentication. Configure hostRules instead.
rarkins and others added 6 commits April 5, 2021 14:34
@rarkins
feat: remove logLevel support in config (#9390)
070136f 
Remove support for logLevel in config. Must be configured using LOG_LEVEL instead.

Closes #8291

BREAKING CHANGE: Configure LOG_LEVEL in env and not in config or CLI
@rarkins
feat: split trustLevel into separate options (#9388)
ed3595e 
Removes trustLevel and replaces it with 3 other options instead. No longer necessary to set anything additional is configuring `allowedPostUpgradeCommands`

BREAKING CHANGE: `trustLevel` is no longer supported and instead broken into `allowCustomCrateRegistries` , `allowScripts` , and `exposeAllEnv`.
@rarkins
feat(config): remove manager additionalBranchPrefix defaults (#9373)
91ba144 
Resets any language or manager` additionalBranchPrefix` values to empty string. Add the `compatibility:additionalBranchPrefix` prefix to restore previous behavior.

BREAKING CHANGE: Removal of default `additionalBranchPrefix` values will cause branch names to change for docker/helm/buildkite/cargo/homebrew.
@rarkins
feat: updateType=patch (#9393)
9a47d1e 
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
@secustor @rarkins
feat(terraform): rework dep types (#9116)
551cc79 
Improves the `depType` values returned by the terraform manager.

Closes #8792

BREAKING CHANGE: Values for extracted `depType` in terraform manager have changed, please see the `terraform` manager readme for details.
@HonkingGoose @rarkins
docs: improve sentences (#9395)
05b2ed1
@rarkins
Merge branch 'v25' into breaking/npmrc-home-dir
a0b46f4 
# Conflicts:
#	docs/usage/private-modules.md
@rarkins rarkins requested a review from viceice April 6, 2021 11:58
@rarkins rarkins merged commit 2f54919 into v25 Apr 6, 2021
@rarkins rarkins deleted the breaking/npmrc-home-dir branch April 6, 2021 12:20
rarkins added a commit that referenced this pull request Apr 7, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
d47c8de 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 10, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
d6860a9 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 11, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
4bec0b8 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 15, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
6a0c858 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 21, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
c75dd75 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
e13a4be 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
cd8eb2d 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
2bad77b 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
@rarkins
feat(npm): remove ~/.npmrc support (#9400)
e7b5be9 
Drops support for reading `.npmrc` from the bot's home directory.

BREAKING CHANGE: Renovate will no longer read from ~/.npmrc. Configure `npmrc` in config instead.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rarkins @viceice @secustor @HonkingGoose