Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore unavailable users #9406

Merged
merged 32 commits into from Apr 22, 2021

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Apr 5, 2021

Changes:

Add logic to filter unavailable users to PR worker and platform API.

Currently this will only have an effect on GitLab, because other platforms either don't have the concept of user availability (Azure DevOps, Gitea, BitBucket) or have the concept, but don't expose it via their API (GitHub).

Context:

Closes #9348

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@fgreinacher
Copy link
Contributor Author

fgreinacher commented Apr 5, 2021

From #9348 (comment)

Sounds like a little research/planning on the algorithm is necessary first. e.g. how it interactions with the various other ways we have for picking assignees.

@rarkins Let's use this PR to discuss 😃

lib/workers/pr/index.ts Outdated Show resolved Hide resolved
lib/workers/pr/index.ts Outdated Show resolved Hide resolved
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Apr 5, 2021

Generally I think I'd prefer a generic config option (e.g. filterUsersBasedOnAvailability) over a GitLab-specific one (as suggested in my original issue) to allow adding similar support to other platforms in the future.

@rarkins
Copy link
Collaborator

rarkins commented Apr 14, 2021

Sure, a single feature but with documentation mentioning which platforms support it would be good. It would be nice if you scan do a quick "scoping" for each platform with this PR to work out which could be supported and which do not have the concept yet.. even if not all are implemented.

@fgreinacher
Copy link
Contributor Author

It would be nice if you scan do a quick "scoping" for each platform with this PR to work out which could be supported and which do not have the concept yet.. even if not all are implemented.

I updated the description to describe platform support a bit more. Based on that we need to stay with GitLab only for now...

@fgreinacher fgreinacher marked this pull request as ready for review April 18, 2021 10:21
lib/workers/pr/index.spec.ts Show resolved Hide resolved
lib/workers/pr/index.ts Outdated Show resolved Hide resolved
lib/platform/gitlab/index.ts Outdated Show resolved Hide resolved
lib/platform/gitlab/index.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Apr 19, 2021
lib/workers/repository/init/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/pr/index.spec.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small changes

lib/workers/repository/init/index.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/index.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice
Copy link
Member

viceice commented Apr 22, 2021

@rarkins LGTM

@rarkins rarkins merged commit 2cc751a into renovatebot:main Apr 22, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fgreinacher fgreinacher deleted the feat/filter-unavailable-users branch April 23, 2021 10:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider GitLab user availability when assigning MRs
5 participants