Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): remove ignoreNpmrcFile support #9409

Merged
merged 2 commits into from Apr 6, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 6, 2021

Changes:

Removes support for the ignoreNpmrcFile config option.

Context:

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
@rarkins rarkins changed the base branch from master to v25 April 6, 2021 07:20
lib/manager/npm/extract/index.ts Show resolved Hide resolved
lib/manager/npm/extract/index.ts Outdated Show resolved Hide resolved
@viceice viceice added the breaking Breaking change, requires major version bump label Apr 6, 2021
viceice
viceice previously approved these changes Apr 6, 2021
lib/manager/npm/extract/index.spec.ts Show resolved Hide resolved
lib/manager/npm/extract/index.ts Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins merged commit 3899d7c into v25 Apr 6, 2021
@rarkins rarkins deleted the breaking/remove-ignore-npmrc-file branch April 6, 2021 11:06
rarkins added a commit that referenced this pull request Apr 7, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 10, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 11, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 15, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 21, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
rarkins added a commit that referenced this pull request Apr 22, 2021
Removes support for the ignoreNpmrcFile config option.

BREAKING CHANGE: ignoreNpmrcFile is no longer supported. Use an empty string for config.npmrc instead.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants