Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): delay global config preset resolution #9415

Merged
merged 1 commit into from Apr 6, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 6, 2021

Changes:

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

Context:

BREAKING CHANGE: Config presets will be resolved after platform initialization, so platform credentials cannot be placed in presets.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

…tion

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so platform credentials cannot be placed in presets.
@rarkins rarkins requested a review from viceice April 6, 2021 14:45
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing, LGTM otherwise

lib/workers/global/index.ts Show resolved Hide resolved
@rarkins rarkins merged commit 094244d into v25 Apr 6, 2021
@rarkins rarkins deleted the breaking/global-config-resolution branch April 6, 2021 15:14
rarkins added a commit that referenced this pull request Apr 7, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 10, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 11, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 15, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 21, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 22, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 22, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 22, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins added a commit that referenced this pull request Apr 22, 2021
…tion (#9415)

Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.

BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
@rarkins
Copy link
Collaborator Author

rarkins commented Apr 26, 2021

There's no easy way to handle that, because extends are passed through and treated like repository config, which takes precedence over admin config. You can use this instead to get the same:

  "extends": [
    ":semanticPrefixFixDepsChoreOthers",
    ":updateNotScheduled",
    ":automergeDisabled",
    ":ignoreModulesAndTests",
    ":autodetectPinVersions",
    "group:monorepos",
    "group:recommended",
    "workarounds:all"
  ],
  prHourlyLimit: 30,
  prConcurrentLimit: 30,

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants