New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): delay global config preset resolution #9415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so platform credentials cannot be placed in presets.
viceice
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small thing, LGTM otherwise
viceice
approved these changes
Apr 6, 2021
rarkins
added a commit
that referenced
this pull request
Apr 7, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 10, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 11, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 15, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 21, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
…tion (#9415) Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work. BREAKING CHANGE: Config presets will be resolved after platform initialization, so from now on platform credentials cannot be placed in presets.
There's no easy way to handle that, because
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Delay config preset resolution in admin config until after platform initialization. This will enable resolution of private “local>…” presets to work.
Context:
BREAKING CHANGE: Config presets will be resolved after platform initialization, so platform credentials cannot be placed in presets.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: