feat(node): remove hard-coded docker grouping #9469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
viceice
approved these changes
Apr 9, 2021
rarkins
added a commit
that referenced
this pull request
Apr 10, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 11, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 15, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 21, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
rarkins
added a commit
that referenced
this pull request
Apr 22, 2021
Remove hardcoded Node.js rules from docker extract and instead add group:nodeJs to group:recommended BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removes hardcoded rule for changing node commit message in Docker extractions, and instead replaces it with a preset.
Context:
BREAKING CHANGE: node images founds in Dockerfiles will no longer have hardcoded commitMessageTopic. Add group:Nodejs or config:base to extends for backwards compatibility.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: