Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): retain npmrc lines without variables #9484

Merged
merged 1 commit into from Apr 10, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 10, 2021

Changes:

Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

Context:

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit ce11381 into v25 Apr 10, 2021
@rarkins rarkins deleted the breaking/npmrc-lines branch April 10, 2021 04:53
rarkins added a commit that referenced this pull request Apr 11, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
rarkins added a commit that referenced this pull request Apr 15, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
rarkins added a commit that referenced this pull request Apr 21, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
rarkins added a commit that referenced this pull request Apr 22, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
rarkins added a commit that referenced this pull request Apr 22, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
rarkins added a commit that referenced this pull request Apr 22, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
rarkins added a commit that referenced this pull request Apr 22, 2021
Instead of ignoring the entire .npmrc file if it contains environment variables, instead just strip out the necessary lines.

BREAKING: .npmrc files with environment variables will no longer be completely ignore - instead only the lines with variables will be stripped.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant