Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace some TODO items with issue ids #9596

Merged
merged 3 commits into from Apr 26, 2021

Conversation

zharinov
Copy link
Collaborator

Changes:

Nothing should be changed

Context:

This PR covers TODOs that aren't related to type issues.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov marked this pull request as ready for review April 25, 2021 15:59
@@ -6,7 +6,6 @@ const content = loadFixture(__filename, 'travis.yml');
describe(getName(__filename), () => {
describe('updateDependency', () => {
it('updates values', () => {
// TODO: should be `Upgrade`
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -20,7 +20,6 @@ export function updateDependency({
quote = '';
}
let newString = `node_js:\n`;
// TODO: `newValue` is a string!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zharinov
Copy link
Collaborator Author

Just like "bad candies" accompany our New Year celebration being left intact during Christmas, the remaining TODO items look hard for me to formalize. Therefore, this PR is ready for review.

@rarkins
Copy link
Collaborator

rarkins commented Apr 25, 2021

What do you think about meaning the description in place and a short issue number after it (eg (#1234))

@zharinov zharinov force-pushed the refactor/replace-todo-with-issues branch from ae2b13b to 92b3d46 Compare April 25, 2021 20:52
@rarkins rarkins enabled auto-merge (squash) April 26, 2021 20:02
@rarkins rarkins merged commit 38620be into renovatebot:main Apr 26, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants