YAMLException on GitLab reference syntax

[dlouzan]

What Renovate type, platform and version are you using?

Latest GitLab template with 24.117.0 from https://gitlab.com/renovate-bot/renovate-runner/

Describe the bug

Renovate fails to extract a project that uses the !reference syntax, as discussed previously on #9162

This is loaded from a gitlab-ci include, outline structure:

.gitlab/ci_templates/.terraform-templates.yml:

.terraform-init:
  script:
    - terraform init ...

...

.terraform-plan:
  extends: .terraform-image
  script:
    - !reference [.terraform-init, script]
    - terraform plan

.gitlab-ci.yml:

include:
  - local: '/.gitlab/ci_templates/.terraform-templates.yml'

...

actual-job:
  stage: test
  extends:
    - .terraform-plan

Relevant debug logs

Click me to see logs

"err": {
  "name": "YAMLException",
  "reason": "unknown tag !<!reference>",
  "mark": {
    ...
  },
  "message": "unknown tag !<!reference> at line 29, column 43:\n     ... erence [.terraform-init, script]\n                                         ^",
         "stack": "YAMLException: unknown tag !<!reference> at line 29, column 43:\n     ... erence [.terraform-init, script]\n                                         ^\n    at generateError (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:167:10)\n    at throwError (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:173:9)\n    at composeNode (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1434:7)\n    at readBlockSequence (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:955:5)\n    at composeNode (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1358:12)\n    at readBlockMapping (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1089:11)\n    at composeNode (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1359:12)\n    at readBlockMapping (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1089:11)\n    at composeNode (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1359:12)\n    at readDocument (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1525:3)\n    at loadDocuments (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1588:5)\n    at load (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1614:19)\n    at Object.safeLoad (/usr/src/app/node_modules/js-yaml/lib/js-yaml/loader.js:1637:10)\n    at Object.extractAllPackageFiles (/usr/src/app/node_modules/renovate/lib/manager/gitlabci/extract.ts:103:18)\n    at Object.extractAllPackageFiles (/usr/src/app/node_modules/renovate/lib/manager/index.ts:62:17)\n    at Object.getManagerPackageFiles (/usr/src/app/node_modules/renovate/lib/workers/repository/extract/manager-files.ts:33:29)\n    at /usr/src/app/node_modules/renovate/lib/workers/repository/extract/index.ts:48:28\n    at async Promise.all (index 0)\n    at Object.extractAllDependencies (/usr/src/app/node_modules/renovate/lib/workers/repository/extract/index.ts:46:26)\n    at Object.extract (/usr/src/app/node_modules/renovate/lib/workers/repository/process/extract-update.ts:82:20)"
       },
       "file": ".gitlab/ci_templates/.terraform-templates.yml"

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

• I have provided a minimal reproduction repository
• I don't have time for that, but it happens in a public repository I have linked to
• I don't have time for that, and cannot share my private repository
• The nature of this bug means it's impossible to reproduce publicly

Additional context

[viceice]

Looks like my reference replace code got lost

[github-actions]

Hi there,

The Renovate team needs your help! Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on minimal reproductions to understand what is needed.

We may close the issue if you have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[tmeijn]

Hey @viceice seems like you use replaceReferenceTags in the gitlabci manager but not in the gitlabci-include manager.

Also, the regex seems too strict. I think it's best to just match anything within the brackets after !reference like so: https://regex101.com/r/LGL79P/1, because it could be anything ([job name with space and no starting dot, artifacts, name]).

Monkey patching these two suggestions into my local Node modules seems to make it work again. I created a PR here with the suggested changes here.

[viceice]

PR looks good, but needs a test case

[renovate-release]

🎉 This issue has been resolved in version 25.4.6 🎉

The release is available on:

• GitHub release
• 25.4.6

Your semantic-release bot 📦🚀