Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): validate packageRules matchUpdateTypes combos #9649

Merged
merged 6 commits into from Apr 22, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 20, 2021

Changes:

Adds validation to throw errors if invalid config options are combined with matchUpdateTypes in packageRules.

Context:

Some of these are a common mistake.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs snapshot update

@rarkins rarkins enabled auto-merge (squash) April 22, 2021 06:19
@viceice
Copy link
Member

viceice commented Apr 22, 2021

candidate to backport to v24 😉

@rarkins rarkins merged commit 61abc03 into master Apr 22, 2021
@rarkins rarkins deleted the feat/package-rules-update-types-validation branch April 22, 2021 07:16
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants