New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(terraform): support github repo source url with underscores #9661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have new tests.
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice Added some unit tests for the github source regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My expectation was to add tests for the function which are suing the regexes and not the regex directly 🤔
@rarkins Should we ok with only testing the regex directly?
I think that's ok, thanks |
🎉 This PR is included in version 25.3.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: Rhys Arkins <rhys@arkins.net>
Changes:
Adds underscore to the list of whitelisted characters for the
githubRefMatchRegex
so that repositories with an underscore don't get truncated for Terraform and Terragrunt managers.Context:
Our repo has an underscore and was getting truncated like below which resulted in us getting the "Failed to look up dependency" warning message:
Before
After
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: