Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate unable to resolve private shareable preset #9665

Closed
1 of 4 tasks
hisabimbola opened this issue Apr 21, 2021 · 2 comments
Closed
1 of 4 tasks

Renovate unable to resolve private shareable preset #9665

hisabimbola opened this issue Apr 21, 2021 · 2 comments
Labels
type:bug Bug fix of existing functionality

Comments

@hisabimbola
Copy link

hisabimbola commented Apr 21, 2021

What Renovate type, platform and version are you using?

Self-hosted Renovate
Version: renovate/renovate:24.119.4

Describe the bug

When a preset is stored in a private repo, renovate is not able to fetch the preset.

Relevant debug logs
I created a sample repo here

You can see that it could not fetch the preset repo, even though there is a valid token.

Click me to see logs
DEBUG: Using RE2 as regex engine
DEBUG: Parsing configs
DEBUG: Checking for config file in /github/workspace/dist/src/renovate-config.js
DEBUG: GitHub 404
       "url": "https://api.github.com/repos/hisabimbola/renovate-base/contents/base.json"
DEBUG: Failed to retrieve base.json from repo
       "statusCode": 404,
       "url": "https://api.github.com/repos/hisabimbola/renovate-base/contents/base.json"
DEBUG: Preset fetch error
       "preset": "github>hisabimbola/renovate-base:base",
       "err": {
         "message": "dep not found",
         "stack": "Error: dep not found\n    at fetchJSONFile (/usr/src/app/node_modules/renovate/lib/config/presets/github/index.ts:33:11)\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n    at Object.fetchPreset (/usr/src/app/node_modules/renovate/lib/config/presets/util.ts:59:19)\n    at getPreset (/usr/src/app/node_modules/renovate/lib/config/presets/index.ts:184:22)\n    at Object.resolveConfigPresets (/usr/src/app/node_modules/renovate/lib/config/presets/index.ts:259:27)\n    at Object.parseConfigs (/usr/src/app/node_modules/renovate/lib/config/index.ts:56:22)\n    at Object.start (/usr/src/app/node_modules/renovate/lib/workers/global/index.ts:76:14)\n    at /usr/src/app/node_modules/renovate/lib/renovate.ts:16:22"
       }
 INFO: Throwing preset error
       "validationError": "Cannot find preset's package (github>hisabimbola/renovate-base:base)"
FATAL: Fatal error: config-validation
       "err": {
         "validationError": "Cannot find preset's package (github>hisabimbola/renovate-base:base)",
         "message": "config-validation",
         "stack": "Error: config-validation\n    at Object.resolveConfigPresets (/usr/src/app/node_modules/renovate/lib/config/presets/index.ts:270:25)\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)\n    at Object.parseConfigs (/usr/src/app/node_modules/renovate/lib/config/index.ts:56:22)\n    at Object.start (/usr/src/app/node_modules/renovate/lib/workers/global/index.ts:76:14)\n    at /usr/src/app/node_modules/renovate/lib/renovate.ts:16:22"
       }
DEBUG: Missing config
DEBUG: Renovate exiting

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

Additional context

Initial discussion about this issue here

@hisabimbola hisabimbola added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Apr 21, 2021
@hisabimbola
Copy link
Author

Issue is fixed in v25 release #9394

@viceice viceice removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 22, 2021
@rarkins
Copy link
Collaborator

rarkins commented Apr 22, 2021

Great, thanks for your patience getting to the root of it

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants