Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): repect allowScripts & ignoreScripts #9684

Merged
merged 4 commits into from Apr 22, 2021
Merged

fix(npm): repect allowScripts & ignoreScripts #9684

merged 4 commits into from Apr 22, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Apr 22, 2021

Changes:

Do not add --ignore-scripts when allowScripts == true && ignoreScripts != true

Context:

fixes #9648

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins April 22, 2021 14:10
rarkins
rarkins previously approved these changes Apr 22, 2021
@viceice viceice enabled auto-merge (squash) April 22, 2021 14:18
@viceice
Copy link
Member Author

viceice commented Apr 22, 2021

Snapshot failures 🙈

@viceice viceice merged commit 8c0f7c1 into main Apr 22, 2021
@viceice viceice deleted the fix/npm-scripts branch April 22, 2021 15:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ignoreScripts" option doesn't work in case of "npm"
3 participants