Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(poetry): lockFileMaintenance #9695

Merged
merged 4 commits into from Apr 26, 2021
Merged

fix(poetry): lockFileMaintenance #9695

merged 4 commits into from Apr 26, 2021

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Apr 22, 2021

Changes:

Context:

close #9231

Documentation (please check one with an [x])

  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rarkins Backport to v24?

@rarkins
Copy link
Collaborator

rarkins commented Apr 23, 2021

We use config.isLockFileMaintenance elsewhere. I was thinking that is<updateType> should be automatically populated. Is the problem because multiple updates are in one config?

@trim21
Copy link
Contributor Author

trim21 commented Apr 23, 2021

I logged the config object,updatedDeps is empty when lock file maintenance

@rarkins
Copy link
Collaborator

rarkins commented Apr 23, 2021

@rarkins Backport to v24?

Not until I understand if or why other config.isLockFileMaintenance references in our code base work

@trim21
Copy link
Contributor Author

trim21 commented Apr 26, 2021

what's blocking this? Is there anything I need to do?

@viceice
Copy link
Member

viceice commented Apr 26, 2021

@trim21 we need to find the cause why config.isLockFileMaintenance is not working as expected.

Your pr is a workaround and not a fix for the root cause.

@rarkins
Copy link
Collaborator

rarkins commented Apr 26, 2021

I've created #9728 so I'm ok to merge this in the meantime

@rarkins rarkins enabled auto-merge (squash) April 26, 2021 14:21
@rarkins rarkins merged commit fb50312 into renovatebot:main Apr 26, 2021
@trim21 trim21 deleted the fix/poetry/lock-file-maintenance branch April 26, 2021 14:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry.lock can't get updated
4 participants