refactor: Cache moo lexer instances #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as parsing code is synchronous, there should not be problems |
viceice
reviewed
Apr 23, 2021
lib/manager/bazel/extract.ts
Outdated
Comment on lines
158
to
159
| lexer.reset(); | ||
|
|
There was a problem hiding this comment.
Suggested change
| lexer.reset(); |
I think this is not needed. 🤔
lib/manager/cake/index.ts
Outdated
| @@ -67,5 +66,6 @@ export function extractPackageFile(content: string): PackageFile { | |||
| } | |||
| token = lexer.next(); | |||
| } | |||
| lexer.reset(); | |||
There was a problem hiding this comment.
Suggested change
| lexer.reset(); |
lib/manager/gradle-lite/tokenizer.ts
Outdated
| ({ type, offset, value }) => ({ type, offset, value } as Token) | ||
| ); | ||
| lexer.reset(); |
There was a problem hiding this comment.
Suggested change
| lexer.reset(); |
viceice
approved these changes
Apr 23, 2021
|
🎉 This PR is included in version 25.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Don't create new object each time we need to parse something.
Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: