Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for forkToken #9701

Merged
merged 9 commits into from Apr 24, 2021

Conversation

Chumper
Copy link
Contributor

@Chumper Chumper commented Apr 23, 2021

Changes:

Added documentation

Context:

I provide the forking GitHub App as well internally in the company.
So I completed the documentation for this workflow

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Apr 23, 2021
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
@@ -200,6 +200,13 @@ It will also override any settings in `packageRules`.
## forkMode

You probably have no need for this option - it is an experimental setting for the Renovate hosted GitHub App.
However, if this is set to true then Renovate will clone the repository before working on the clone and creating Pull Requests on the parent (GitHub only).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
However, if this is set to true then Renovate will clone the repository before working on the clone and creating Pull Requests on the parent (GitHub only).
However, if this is set to `true` then Renovate will clone the repository before working on the clone and creating Pull Requests on the parent (GitHub only).

Let's put true in monospaced font.

Also it's really confusing to read: "Renovate will clone the repository before working on the clone"...
I don't know what the behavior is, but the way its worded now is not helping me understand what's happening.

The way I understand Renovate is that it always clones the repo before doing stuff???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, wording is misleading, I meant fork instead of clone. Let me rephrase.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, wording is misleading, I meant fork instead of clone. Let me rephrase.

I thought some wires got crossed somewhere. 😄
I'll let you rephrase this. 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the wording, does it make more sense now?

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a suggestion to fix up a line of text.

I'm not clear on what "personal space" refers to. What/where is this "personal space"? Do we need to use this term to understand what the feature does differently compare to the default Renovate bot behavior? I'm thinking that maybe this is too much detail and will only confuse readers? But maybe we do need to explain this concept?

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@Chumper
Copy link
Contributor Author

Chumper commented Apr 23, 2021

The personal space for me is where all repos under https://github.com/Chumper?tab=repositories are, so all repos that are not under an organization like renovatebot here and that I am the owner of.

Maybe personal repositories is a better name.

As a PAT always belongs to a user account on GitHub, there is always a personal space where repositories can be forked into.

@rarkins rarkins enabled auto-merge (squash) April 24, 2021 05:39
@rarkins rarkins merged commit 90e9680 into renovatebot:main Apr 24, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants