Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find the cause why config.isLockFileMaintenance is not working as expected #9728

Closed
rarkins opened this issue Apr 26, 2021 · 4 comments · Fixed by #14005
Closed

Find the cause why config.isLockFileMaintenance is not working as expected #9728

rarkins opened this issue Apr 26, 2021 · 4 comments · Fixed by #14005
Labels
priority-2-high Bugs impacting wide number of users or very important features status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 26, 2021

we need to find the cause why is not working as expected.

Your pr is a workaround and not a fix for the root cause.

Originally posted by @viceice in #9695 (comment)

@rarkins rarkins added priority-2-high Bugs impacting wide number of users or very important features status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Apr 26, 2021
@trim21
Copy link
Contributor

trim21 commented Apr 26, 2021

dashboard isn't updated either in the provided repo, didn't know if these bugs are relative.

@viceice
Copy link
Member

viceice commented Apr 27, 2021

dashboard isn't updated either in the provided repo, didn't know if these bugs are relative.

This happen when renovate automerge a branch /pr. Dashboard will be updated on next run. There is an existing issue somewhere around.

@msw-kialo
Copy link
Contributor

msw-kialo commented Jan 20, 2022

After a longer debugging session I suspect this is broken for all managers that use it (I had the issues with pip-compile): Based of the code in lib/workers/repository/updates/flatten.ts I think that this updateType is simply set

lockFileConfig.updateType = 'lockFileMaintenance';
after the is* properties are:
if (updateConfig.updateType) {
updateConfig[`is${upper(updateConfig.updateType)}`] = true;
}
if (updateConfig.updateTypes) {
updateConfig.updateTypes.forEach((updateType) => {
updateConfig[`is${upper(updateType)}`] = true;
});
}

Adding lockFileConfig.isLockfileUpdate = true; locally afterwards fixed the issue for me, but I am not sure whether this is the proper fix.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 31.66.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-2-high Bugs impacting wide number of users or very important features status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants