Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitlabci): filter out !reference tags in gitlabci-include #9741

Merged
merged 8 commits into from Apr 28, 2021

Conversation

tmeijn
Copy link
Contributor

@tmeijn tmeijn commented Apr 27, 2021

Changes:

  • use the replaceReferenceTags function also in gitlabci-include/extract
  • make the regex more loose since the content in the brackets is a bit arbitrary

Context:

Closes #9620

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository (my own private one), or
  • Both unit tests + ran on a real repository

Closes #9620

@tmeijn tmeijn changed the title Draft: fix(gitlabci): filter out !reference tags also in gitlabci-include with more loose regex fix(gitlabci): filter out !reference tags also in gitlabci-include with more loose regex Apr 27, 2021
@tmeijn tmeijn marked this pull request as draft April 27, 2021 12:31
@viceice viceice self-requested a review April 27, 2021 13:04
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case.

@tmeijn
Copy link
Contributor Author

tmeijn commented Apr 28, 2021

@viceice WDYT about this? Added the !reference tags to the original fixture to prove that existing YAMLs will not be affected.

@tmeijn tmeijn requested a review from viceice April 28, 2021 10:29
@HonkingGoose
Copy link
Collaborator

@tyronedd Did you know that you can link a PR to a issue? That way the linked issue is closed automatically when the PR gets merged.

You can use keywords like closes, resolves, or fixes with a issue number to automatically close the issue when the PR is merged. You can use these keywords in your PR description (top post of the PR), or in a commit message.

Example:

Closes #9620

https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@rarkins rarkins marked this pull request as ready for review April 28, 2021 12:36
@rarkins rarkins changed the title fix(gitlabci): filter out !reference tags also in gitlabci-include with more loose regex fix(gitlabci): filter out !reference tags in gitlabci-include Apr 28, 2021
@rarkins rarkins merged commit 038f52c into renovatebot:main Apr 28, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tmeijn tmeijn deleted the patch-2 branch April 28, 2021 14:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YAMLException on GitLab reference syntax
5 participants