separateMajorMinor=false patch grouping broken since v25.0.0

[ahippler]

What Renovate type, platform and version are you using?

self-hosted bitbucket-server

Describe the bug

Since v25.0.0 it is not possible to combine all changes of a group.

{
    "packageRules": [
        {
            "groupName": "all",
            "packagePatterns": ["*"],
            "separateMinorPatch": false,
            "separateMajorMinor": false,
            "separateMultipleMajor": false
        }
    ]
}

did produce 1 PR before 25.0.0 and after the update there is an additional renovate/patch-all branch.

Relevant debug logs

package.json

{
    "name": "test",
    "version": "0.0.1",
    "devDependencies": {
        "lodash": "4.17.20",
        "sinon": "9.0.0"
    }
}

renovate.json

{
    "packageRules": [
        {
            "groupName": "all",
            "packagePatterns": ["*"],
            "separateMinorPatch": false,
            "separateMajorMinor": false,
            "separateMultipleMajor": false
        }
    ]
}

v25.4.1: DEBUG: Processing 2 branches: renovate/all, renovate/patch-all
v25.0.0: DEBUG: Processing 2 branches: renovate/all, renovate/patch-all
v24.119.11: DEBUG: Processing 1 branch: renovate/all

[github-actions]

Hi there,

The Renovate team needs your help! Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on minimal reproductions to understand what is needed.

We may close the issue if you have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[rarkins]

Can you put this into a simple public github.com repo that we can fork to test? No need to run any bot against it first

[ahippler]

https://github.com/ahippler/renovate-combine-all

[github-actions]

Thank you for providing a reproduction! 🎉 🚀

The Renovate team will take a look at the reproduction repository. Once we confirm the provided repository reproduces the problem, the label will be changed to reproduction:confirmed.

[trim21]

@trim21 actually what you are seeing is definitely different. The hosted bot/app is not running v25 yet

No, I'm running renovate cli v25 on this repo. I just update renovate config, remove all extra config.

=========

https://github.com/Trim21/poetry-lock-cannot-update/issues/19 this issue is created by renovate cli v25

This issue contains a list of Renovate updates and their statuses.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to ignore the schedule.

• chore(deps): update deps-prod (patch) (sphinx, sphinx-rtd-theme)
• chore(deps-dev): update deps-dev (patch) (pytest, pytest-github-actions-annotate-failures)
• chore(deps-dev): update deps-dev (flake8, flake8-bugbear, flake8-comprehensions, pre-commit)

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, check the box below.

• chore(deps): pin dependencies (requests, typing_extensions)

[renovate-release]

🎉 This issue has been resolved in version 25.4.3 🎉

The release is available on:

• GitHub release
• 25.4.3

Your semantic-release bot 📦🚀

[viceice]

@trim21 Please try v25.4.3, which was just released.

[trim21]

@viceice fixed, thanks