Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch grouping when separateMinorPatch=false #9746

Merged
merged 1 commit into from Apr 27, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 27, 2021

Changes:

Fixes logic so that patch updates don't separate themselves from groupings.

Context:

Previously, if updateType=patch then it could only be because separateMinorPatch=true, but now that is not the case and the extra checks are required.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit bafb55d into main Apr 27, 2021
@rarkins rarkins deleted the fix/9744-patch-grouping branch April 27, 2021 14:14
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hisener
Copy link
Contributor

hisener commented May 11, 2021

@rarkins Maybe a stupid question but why don't we have update.updateType === 'minor' check here?

We use 6.1.7.Final of hibernate-validator and there is only one upgrade PR from 6.1.7.Final to 7.0.1.Final even though the configuration is:

{
  "packagePatterns": [
    "^version\\.hibernate-validator$",
  ],
  "separateMajorMinor": true,
  "separateMinorPatch": true
}

It could also because of grouping or .Final at the end, not sure. Does this ring a bell?

@rarkins
Copy link
Collaborator Author

rarkins commented May 11, 2021

Can you create a reproduction repo to demonstrate and create a new discussion?

@hisener
Copy link
Contributor

hisener commented May 17, 2021

Update: I couldn't reproduce it in a public repo. There two PRs as expected: hisener/renovate-tests#60 and hisener/renovate-tests#61.

First, I will upgrade the Renovate version. Probably that's the issue.

@hisener
Copy link
Contributor

hisener commented May 27, 2021

Another update: Filed #10190. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants