Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gomod): use latest go version when binarySource=docker #9764

Merged
merged 1 commit into from Apr 28, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 28, 2021

Changes:

Changes go constraint detection to be "greater than or equal to", as recommended by Go maintainers.

Context:

Fixes #9761, maybe others

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins changed the title fix(worker): wrong no branch delete on dry-run (#9682) fix(gomod): use latest go version when binarySource=docker Apr 28, 2021
@rarkins rarkins marked this pull request as draft April 28, 2021 09:44
@rarkins rarkins marked this pull request as ready for review April 28, 2021 13:13
@rarkins rarkins merged commit d9de349 into v24 Apr 28, 2021
@rarkins rarkins deleted the fix/v24-go-constraints branch April 28, 2021 13:45
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.119.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants