feat(argocd): implement manager #9771
Conversation
| config?: ExtractConfig | ||
| ): PackageFile | null { | ||
| // check for argo reference. API version for the kind attribute is used | ||
| if (fileTestRegex.test(content) === false) { |
There was a problem hiding this comment.
Nice, so we can save parsing phase if we know this is no argocd document. 👍
@rarkins I think we can enable it by default for all yaml files as this regex will ignore files which do not have argocd content.
There was a problem hiding this comment.
My main concern is that repos may have hundreds of YAML files while only a very small fraction would be argo or even use argo.
Is there any naming convention which would cover maybe 80%+ of the files e.g. /argo.*\.yaml$/i ?
If so then I'd prefer that as the default. But if not, it could be ok to default to all .yaml
There was a problem hiding this comment.
No, there aren't such conventions.
Basically this is updating Kubernetes manifests which contain ArgoCD CR manifests. Because of that fact every .yaml could contain an ArgoCD manifest.
There was a problem hiding this comment.
OK, let's see how it goes then. I think we may read detected files into memory in parallel, so it could increase memory use by a lot if there are large YAML files.
|
🎉 This PR is included in version 25.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
This PR implements basic capabilities to renovate ArgoCD application definitions.
File matches are empty by default as Argo uses yaml files, therefore I'm mimicking the Kubernetes manager here.
Supported references are:
Context:
Closes #7416
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
https://github.com/secustor/renovate_argocd_test/