refactor: separate update generation #9788
Conversation
| @@ -170,12 +170,10 @@ Object { | |||
|
|
|||
| exports[`workers/repository/process/lookup/index .lookupUpdates() handles git submodule update 1`] = ` | |||
| Object { | |||
| "currentVersion": undefined, | |||
There was a problem hiding this comment.
Need to check this isn't a mistake
There was a problem hiding this comment.
It's because you moved the versioning.valueToVersion call to inside the isValid condition and git submodules don't have a current value.
@JamieMagee Maybe we should pass the tracking branch as current value and add a git versioning, which allows branches / tags as version?
There was a problem hiding this comment.
So we call valueToVersion now only on valid currentValue. Maybe we should mark this pr as feature, as it causes a bahavior change here.
| @@ -170,12 +170,10 @@ Object { | |||
|
|
|||
| exports[`workers/repository/process/lookup/index .lookupUpdates() handles git submodule update 1`] = ` | |||
| Object { | |||
| "currentVersion": undefined, | |||
There was a problem hiding this comment.
It's because you moved the versioning.valueToVersion call to inside the isValid condition and git submodules don't have a current value.
@JamieMagee Maybe we should pass the tracking branch as current value and add a git versioning, which allows branches / tags as version?
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
| @@ -170,12 +170,10 @@ Object { | |||
|
|
|||
| exports[`workers/repository/process/lookup/index .lookupUpdates() handles git submodule update 1`] = ` | |||
| Object { | |||
| "currentVersion": undefined, | |||
There was a problem hiding this comment.
So we call valueToVersion now only on valid currentValue. Maybe we should mark this pr as feature, as it causes a bahavior change here.
|
I've reverted that change so that snapshots remain the same. Will make such a change in a different PR if it's necessary. |
|
🎉 This PR is included in version 25.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Refactors update generation into a separate file.
Context:
Improvements before an upcoming feature.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: