Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve stabilityDays documentation #9792

Conversation

HonkingGoose
Copy link
Collaborator

Changes:

  • Improve existing sentences/rewrite for clarity
  • Warn Maven users not to use stabilityDays if a source provides unreliable last-modified headers
  • Explain that some datasources are not supported because they don't provide timestamps or are just not supported at all

Context:

This change was requested in this discussion: #9784

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@HonkingGoose
Copy link
Collaborator Author

Thank you for the good suggestions! 😄 🥳

@HonkingGoose HonkingGoose marked this pull request as ready for review April 30, 2021 09:35
@rarkins rarkins merged commit 7f7b796 into renovatebot:main Apr 30, 2021
@HonkingGoose HonkingGoose deleted the docs/warn-stabilityDays-nonfunctional-maven branch April 30, 2021 10:15
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants