refactor(hostRules): precalculate resolvedHost #9811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
requested changes
May 1, 2021
rarkins
changed the title
viceice
approved these changes
May 1, 2021
|
🎉 This PR is included in version 25.7.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Calculates a
resolvedHostvalue whenever a host rule is added, and returns it as part offind/findAll.Context:
This allows managers to not have to duplicate "is this a URL or a hostname?" logic. Also important for an upcoming hostRules simplification PR I'm working on.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: