Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): nested packageRules migration #9814

Merged
merged 1 commit into from May 1, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented May 1, 2021

Changes:

Fixes nested packageRules migration so that:

  • a "base" rule is no longer added in addition to the flattened nested rules
  • such rules are inserted in the right sorted order cmopared to other rules

Context:

#9807

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice May 1, 2021 20:31
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work.

@rarkins rarkins merged commit ffd0269 into main May 1, 2021
@rarkins rarkins deleted the fix/migration-nested-package-rules branch May 1, 2021 21:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants