From 3dc0aa9ce6cddd50ffae2a020b2e261656e04657 Mon Sep 17 00:00:00 2001 From: Stefan <5585744+casdevs@users.noreply.github.com> Date: Mon, 2 Nov 2020 09:10:07 +0100 Subject: [PATCH 1/5] Update definitions.ts I noticed that `updateTypes: ['patch']` only matches if `separateMinorPatch` is set to true. This comes somewhat unexpected and does not seem to be documented anywhere at the moment, as opposed to the documentation of the `patch` setting, where the docs correctly state `Only applies if separateMinorPatch is set to true`. Maybe related to https://github.com/renovatebot/renovate/issues/2818 But without reading the docs, I would expect `updateTypes: ['patch']` to always match on patch updates (e.g. 1.0.0 to 1.0.1) regardless of the `separateMinorPatch` setting (which is only set if we want separate PRs or branches for patch AND minor updates) --- lib/config/definitions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts index 3d50d2369e01c8..ad449ca4a98b7c 100644 --- a/lib/config/definitions.ts +++ b/lib/config/definitions.ts @@ -900,7 +900,7 @@ const options: RenovateOptions[] = [ { name: 'updateTypes', description: - 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object.', + 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object. `patch` only matches if `separateMinorPatch` is set to true', type: 'array', // TODO: add allowedValues subType: 'string', From cad67e95b1e8d5d00aee35b59fdc74a702f3ca25 Mon Sep 17 00:00:00 2001 From: Stefan <5585744+casdevs@users.noreply.github.com> Date: Mon, 2 Nov 2020 09:30:36 +0100 Subject: [PATCH 2/5] Update configuration-options.md --- docs/usage/configuration-options.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/usage/configuration-options.md b/docs/usage/configuration-options.md index ce1a0241021531..0ac4a432dea833 100644 --- a/docs/usage/configuration-options.md +++ b/docs/usage/configuration-options.md @@ -1152,9 +1152,12 @@ Use this field to match rules against types of updates. For example to apply a s } ``` +Update type `patch` only matches if `separateMinorPatch` is set to true. + ## patch Add to this object if you wish to define rules that apply only to patch updates. See also `major` and `minor` configuration options. +Only applies if `separateMinorPatch` is set to true. ## php From 364d9a8e70a6522c0efe3a0216e306a89414eaf1 Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Wed, 4 Nov 2020 09:43:07 +0100 Subject: [PATCH 3/5] Update docs/usage/configuration-options.md --- docs/usage/configuration-options.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/usage/configuration-options.md b/docs/usage/configuration-options.md index 3456c9169bbdd6..7661e6cc53c9d4 100644 --- a/docs/usage/configuration-options.md +++ b/docs/usage/configuration-options.md @@ -1268,8 +1268,6 @@ For example to apply a special label for Major updates: } ``` -Update type `patch` only matches if `separateMinorPatch` is set to true. - ## patch Add to this object if you wish to define rules that apply only to patch updates. From d1ab5fd8872364d8f7750271dd133f9945ed7b8d Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Wed, 4 Nov 2020 09:43:47 +0100 Subject: [PATCH 4/5] Update lib/config/definitions.ts --- lib/config/definitions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts index ad449ca4a98b7c..4518c5cc0c5b7c 100644 --- a/lib/config/definitions.ts +++ b/lib/config/definitions.ts @@ -900,7 +900,7 @@ const options: RenovateOptions[] = [ { name: 'updateTypes', description: - 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object. `patch` only matches if `separateMinorPatch` is set to true', + 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object. type: 'array', // TODO: add allowedValues subType: 'string', From 2d86c44e90fd09019e38beb32998ebd3adde740d Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Wed, 4 Nov 2020 09:44:10 +0100 Subject: [PATCH 5/5] Update lib/config/definitions.ts --- lib/config/definitions.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts index 4518c5cc0c5b7c..3d50d2369e01c8 100644 --- a/lib/config/definitions.ts +++ b/lib/config/definitions.ts @@ -900,7 +900,7 @@ const options: RenovateOptions[] = [ { name: 'updateTypes', description: - 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object. + 'Update types to match against (major, minor, pin, etc). Valid only within `packageRules` object.', type: 'array', // TODO: add allowedValues subType: 'string',