Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove explicit dependency on tslib #156

Merged
merged 3 commits into from May 5, 2023

Conversation

JamieMagee
Copy link
Contributor

Looks like this was done back in #54 when there was a mix of dependencies on tslib 1.x and 2.x. This is no longer the case anymore, and I don't think this is required.

@JamieMagee JamieMagee requested a review from viceice May 5, 2023 03:50
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamieMagee
Copy link
Contributor Author

JamieMagee commented May 5, 2023

I just checked and setting importHelpers to true or false doesn't affect the output. I assume that because we're using such a new version of Node, and relatively simple features, there are no downleveling helpers required.

From the docs1:

For certain downleveling operations, TypeScript uses some helper code for operations like extending class, spreading arrays or objects, and async operations. By default, these helpers are inserted into files which use them. This can result in code duplication if the same helper is used in many different modules.

Footnotes

  1. https://www.typescriptlang.org/tsconfig#importHelpers

@JamieMagee JamieMagee enabled auto-merge (squash) May 5, 2023 04:17
@JamieMagee JamieMagee merged commit 9685f1a into main May 5, 2023
10 checks passed
@JamieMagee JamieMagee deleted the refactor/remove-tslib branch May 5, 2023 04:21
@viceice
Copy link
Member

viceice commented May 5, 2023

@JamieMagee you should have made this a fix. chore's don't create a new release. so we need to wait for another change to get it release 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants