Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Long TF plans do not cause a scrollbar to appear in chrome #946

Open
laverya opened this issue May 21, 2019 · 0 comments
Open

Long TF plans do not cause a scrollbar to appear in chrome #946

laverya opened this issue May 21, 2019 · 0 comments
Labels
good first issue Good for newcomers type::bug Something isn't working UI

Comments

@laverya
Copy link
Member

laverya commented May 21, 2019

Expected behavior

When running the terraform step, all plan contents should be visible or there should be a scroll bar.

Actual behavior

A scrollbar never appears, and content clips off the bottom of the screen. If the page zoom is changed, content reflows and a scroll bar appears.

Information

  • Ship version: 0.43.1
  • Command line run: ship init ./ship.yaml
  • Chrome version: 74.0.3729.157 (Official Build) (64-bit) on OS X

The ship.yaml in question:

assets:
  v1:
    - terraform:
        dest: ./terraform/files.tf
        inline: |
          resource "local_file" "foo" {
            content     = "{{repl ConfigOption "id_length" }}"
            filename = "/tmp/foo.bar"
          }
          resource "local_file" "http-tf-check" {
            content     = "${data.http.tf-check.body}"
            filename = "./http.check"
          }
          resource "local_file" "http-example-com-check" {
            content     = "${data.http.example-com.body}"
            filename = "./example.com.check"
          }
          resource "local_file" "random_id" {
            content     = "${random_string.id.result}"
            filename = "./random_id.check"
          }
    - terraform:
        dest: ./terraform/http.tf
        inline: |
          provider "http" {}
          data "http" "tf-check" {
            url = "https://checkpoint-api.hashicorp.com/v1/check/terraform"
            request_headers {
              "Accept" = "application/json"
            }
          }
          data "http" "example-com" {
            url = "https://example.com"
            request_headers {
              "Accept" = "application/json"
            }
          }
    - terraform:
        dest: ./terraform/random.tf
        inline: |
          provider "random" {}
          resource "random_string" "id" {
            length = "{{repl ConfigOption "id_length" }}"
            special = true
            override_special = "/@\" "
          }

config:
  v1:
    - name: id
      items:
         - name: id_length
           title: ID Length
           type: text
           required: true
           default: 80
           help_text: bigger numbers make longer ids

lifecycle:
  v1:
    - message:
        contents: "hi"
    - render: {}
    - terraform:
        path: terraform/
    - message:
        contents: "bye"

Steps to reproduce the behavior

  1. Run ship with terraform contents that produce a long plan
  2. Observe the lack of scroll before changing zoom
  3. Change zoom and observe that scrolling is now possible
@laverya laverya added type::bug Something isn't working good first issue Good for newcomers UI labels May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers type::bug Something isn't working UI
Projects
None yet
Development

No branches or pull requests

1 participant