From 256deeae1487d5d7a488b3c50505775b0a1be510 Mon Sep 17 00:00:00 2001 From: "Fred K. Schott" Date: Sun, 19 Feb 2017 13:57:39 -0800 Subject: [PATCH 1/2] add ISSUE_TEMPLATE, move PR template --- .github/ISSUE_TEMPLATE.md | 54 +++++++++++++++++++ .../PULL_REQUEST_TEMPLATE.md | 0 2 files changed, 54 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md rename PULL_REQUEST_TEMPLATE.md => .github/PULL_REQUEST_TEMPLATE.md (100%) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 000000000..70e7521ee --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,54 @@ + + + + +### Request Options + + +```js +request({ + url: 'http://example.com', // a public URL that we can hit to reproduce, if possible + more: { 'options': 'here' } +}, +``` + +### Expected Behavior + + + + +### Current Behavior + + + +### Possible Solution + + + +### Context + + + +### Your Environment + + +| software | version +| ---------------- | ------- +| request | +| node | +| npm | +| Operating System | diff --git a/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md similarity index 100% rename from PULL_REQUEST_TEMPLATE.md rename to .github/PULL_REQUEST_TEMPLATE.md From 921ebeedb6689f53a113be2c902ea52dbf8d26d2 Mon Sep 17 00:00:00 2001 From: "Fred K. Schott" Date: Sun, 19 Feb 2017 14:13:37 -0800 Subject: [PATCH 2/2] small change to template wording --- .github/ISSUE_TEMPLATE.md | 6 ++++-- .github/PULL_REQUEST_TEMPLATE.md | 6 +++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 70e7521ee..f036dc9a5 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -5,7 +5,7 @@ Please search open/closed issues before submitting since someone might have aske If you have a support request or question please submit them to one of this resources: -* StackOverflow: http://stackoverflow.com/questions/tagged/request+node.js using the tags `node.js` & `request` +* Stack Overflow: http://stackoverflow.com/questions/tagged/request+node.js using the tags `node.js` & `request` * Gitter community: https://gitter.im/request/request?utm_source=newissue * Also have a look at the Readme for more information on how to get support: https://github.com/request/request/blob/master/README.md @@ -14,13 +14,15 @@ Issues on GitHub are only related to problems of request itself and we cannot an support questions here. --> +### Summary -### Request Options +### Simplest Example to Reproduce ```js request({ + method: 'GET', url: 'http://example.com', // a public URL that we can hit to reproduce, if possible more: { 'options': 'here' } }, diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 069c80d9b..0cb35f040 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,10 +3,10 @@ - [ ] I have added/updated tests for any new behavior. -- [ ] An issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here] +- [ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here] + please create an issue to discuss those changes and gather + feedback BEFORE submitting your PR. --> ## PR Description