From 3c94b50a8672b4459d592deb4a906d51e924727a Mon Sep 17 00:00:00 2001 From: garymathews Date: Mon, 20 Jul 2015 14:33:31 -0700 Subject: [PATCH 1/2] Fix: setHeader() with undefined value --- request.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/request.js b/request.js index 6932741c5..f3f5dd915 100644 --- a/request.js +++ b/request.js @@ -573,7 +573,7 @@ Request.prototype.init = function (options) { if (self._form && !self.hasHeader('content-length')) { // Before ending the request, we had to compute the length of the whole form, asyncly - self.setHeader(self._form.getHeaders()) + self.setHeader(self._form.getHeaders(), true) self._form.getLength(function (err, length) { if (!err) { self.setHeader('content-length', length) From 27722fe918a74c7c86bbc4f3af10e3a29072bd20 Mon Sep 17 00:00:00 2001 From: simov Date: Tue, 21 Jul 2015 08:14:45 +0300 Subject: [PATCH 2/2] Test request content-type for multipart/form-data --- tests/test-form-data.js | 3 +++ tests/test-form.js | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tests/test-form-data.js b/tests/test-form-data.js index 605d58e32..0c7ca97d9 100644 --- a/tests/test-form-data.js +++ b/tests/test-form-data.js @@ -29,6 +29,9 @@ function runTest(t, options) { } } + t.ok(/multipart\/form-data; boundary=--------------------------\d+/ + .test(req.headers['content-type'])) + // temp workaround var data = '' req.setEncoding('utf8') diff --git a/tests/test-form.js b/tests/test-form.js index 0c4ef3959..6d719409f 100644 --- a/tests/test-form.js +++ b/tests/test-form.js @@ -21,6 +21,9 @@ tape('multipart form append', function(t) { return } + t.ok(/multipart\/form-data; boundary=--------------------------\d+/ + .test(req.headers['content-type'])) + // temp workaround var data = '' req.setEncoding('utf8')