Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth dependency (likely) incorrectly building the base string when qs contains nested objects #1177

Closed
jesuscript opened this issue Oct 16, 2014 · 5 comments · Fixed by #1610

Comments

@jesuscript
Copy link

opened an issue in the respective library: request/oauth-sign#11

just wanted to bring someone's attention to the issue

@dbellavista
Copy link

Same issue. I'm stuck to request 2.47.1 because oauth is not working.

@nylen
Copy link
Member

nylen commented Dec 11, 2014

I didn't see the original issue, so thanks @dbellavista for commenting!

2.47.1 would be an unpublished version from GitHub, all our published versions end in .0. Is there a particular commit that you're using, or a commit that you've been able to identify as the breaking change?

@dbellavista
Copy link

Sorry, my mistake. I'm using 2.47.0. I noticed the error when a npm update upgraded request to 2.51.0.

@nylen
Copy link
Member

nylen commented Dec 11, 2014

OK, it's most likely a result of #1228 then, which landed in 2.48.0. @dbellavista @jesuscript any chance that one of you can provide a failing test case?

@dbellavista
Copy link

Uh.. While I was working at the minimal working example, I discovered that my problem is not related with this issue, but with the presence of charset=UTF-8 in the content-type header.
I have opened #1313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants