Weird POST behaviour after upgrading to 2.50.0 (from 2.49.0)

[mpangrazzi]

Hi!

I've upgraded request to 2.50.0 and I've noticed a very weird behaviour when doing a request.post (application/x-www-urlencoded).

// client

var request = require('request');

request.post('http://localhost:3000/login', {
  form: { username: 'test', password: 'test' },
  json: true
}, function(err, res, body) {
  console.log(res.body);
});

// server

var express = require('express');
var router = express.Router();

// ...

router.post('/login', function(req, res) {
  console.log(req.body);
  res.json({ status: 'ok' });
});

With request 2.49.0, the req.body on server is the expected:

{ username: 'test', password: 'test' }

With request 2.50.0, the req.body on server is the following:

{ '"username': 'test', password: 'test"' } // ???

I'm using body-parser on Express apps and koa-body on Koa apps.

(obviously, this behaviuor broke all my tests and I have to switch back to 2.49.0)

[nylen]

Don't use form to do JSON POST requests; use body instead.

[simov]

@nylen this is a huge bug, it broke my whole module as well, pushing a temporary fix.

[onemenny]

this is realy annoying
please fix

[simov]

Fixed in #1310

[nylen]

Fixed in version 2.51.0