Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localAddress on redirect #1432

Closed
nytr0gen opened this issue Feb 17, 2015 · 5 comments
Closed

localAddress on redirect #1432

nytr0gen opened this issue Feb 17, 2015 · 5 comments

Comments

@nytr0gen
Copy link

When request performs a redirect with certain opts, it doesn't copy the old opts (I've seen it happen just with localAddress) to the new request that is performing the redirect. Any tips on how to fix it?
@0x4139
Copy link
Contributor

0x4139 commented Feb 18, 2015

I can confirm that this is an issue :), digging up trough the code, i found out that the .init() is called when redirect as well, the problem is that the localAddress opts is not passed forward.

@nylen
Copy link
Member

nylen commented Feb 19, 2015

Patch with tests welcome.

@joshux
Copy link
Contributor

joshux commented Jul 28, 2015

Is this issue fixed in #1437 ?

@simov
Copy link
Member

simov commented Jul 29, 2015

Yes, seems to be fixed here #1460

@joshux do you have any issues with it?

@simov simov closed this as completed Jul 29, 2015
@joshux
Copy link
Contributor

joshux commented Jul 29, 2015

I'm just new, trying to find a bug to fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nylen @joshux @simov @0x4139 @nytr0gen