Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bearer token should not require user #1613

Closed
tracend opened this issue May 29, 2015 · 2 comments
Closed

Bearer token should not require user #1613

tracend opened this issue May 29, 2015 · 2 comments

Comments

@tracend
Copy link

tracend commented May 29, 2015

This is the same issue as #923 from last year

It appears that after this commit that went live as of v2.54.0 the user is set as required with the bearer token.

https://github.com/request/request/blob/master/lib/auth.js#L117

There is no such requirement in the official spec that I'm aware of and the example in the readme doesn't include it.

@simov
Copy link
Member

simov commented May 29, 2015

Hi, @tracend, can you provide a failing test or a short code example to reproduce that bug?

Linking the PR in question #1500

@tracend
Copy link
Author

tracend commented May 30, 2015

I looked through the tests and they seem to be complete.

After further investigation I noticed that my problem was related with the server not responding, and thus the bearer missing.

Having said that, I'm closing this issue with my apologies.

@tracend tracend closed this as completed May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants